Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: tcsh https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226483 mildew@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mildew@xxxxxxxxx ------- Additional Comments From mildew@xxxxxxxxx 2007-02-26 08:54 EST ------- (!!) MUST: rpmlint output: **** Review message: W: tcsh invalid-license distributable ******************** (!!) MUST: Package must meet the Package Naming Guidelines **** Review message: %{?dist} tag is not present. Release should be: 14%{?dist} ******************** (!!) MUST: License field in spec must match actual license. **** Review message: - License: distributable According to http://directory.fsf.org/tcsh.html the license should be BSD ******************** (!!) MUST: The package must successfully compile/build on at least 1 architecture. **** Review message: - Package does not compile successfully. For me, it is due to the missing -ltermcap option when linking. Compiles successfully without the tinfo patch. ******************** (!!) MUST: The spec file MUST handle locales properly. **** Review message: - The package does not use the %find_lang macro ******************** (!!) SHOULD: Packager should query upstream for license text file. **** Review message: - License file is missing. ******************** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review