Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #18 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to comment #17) > Nope, rpmlint complains if you leave it out. The soname is not enough for > this check. However, it is not no-version-dependency-on, it is > no-dependency-on: > > libmsi1-devel.x86_64: W: no-dependency-on libmsi1/libmsi1-libs/liblibmsi1 Doh, that's new for me. Then leave it. > I uploaded a new version. > > Spec URL: http://bonzini.fedorapeople.org/msitools.spec > SRPM URL: http://bonzini.fedorapeople.org/msitools-0.91-1.fc18.src.rpm The spec file is missing changelog for 0.91-1; and the rpm still points to 0.91-1. 0.91-2 throws a 404 in the same place. I need the links to run fedora-review. The spec file is ok though, so i don't think there's any problem; as the link is available it should pass the review. What you could do just to improve it a little bit is widen the description of the packages to 80 columns and format line 36. Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xGSUoXUSYt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review