Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895536 Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- I am generally fine with fixes, I'd just as for two comments in the specfile: 1. Describe why you are removing jars in prep 2. (related to previous) Describe why you are skipping tests It would be nice to replace those seds with something more reliable, so I've filed bug 911277 to make this easier. I'd suggest you put yourself in CC there and replace seds once javapackages-tools supports this. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qSFstfxifl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review