Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #14 from Simone Caronni <negativo17@xxxxxxxxx> --- You're(In reply to comment #13) > "Fedora's RPM includes a %makeinstall macro but it must NOT be used when > make install DESTDIR=%{buildroot} works." > > "must NOT be used" => %make_install is only allowed as last resort, if a > package does not support "make DESTDIR=... install". It's the same thing I thought, but if you read carefully you're mixing %makeinstall with %make_install. The former is forbidden, the latter is allowed. The guidelines say: "Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works." "Instead, Fedora packages should use: %make_install (Note the "_" !), make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install. Those all do the same thing." In fact I thought also the one with the underscore was forbidden, but apparently not. Regards, --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rCsBsG3scP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review