Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910835 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- snotes.spec.old 2013-02-13 17:30:40.000000000 +0100 +++ snotes.spec 2013-02-14 09:20:41.000000000 +0100 @@ -1,13 +1,16 @@ Name: snotes Version: 1.0 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A flexible and easy to use notes system License: MIT URL: https://github.com/v4hn/%{name} Source0: https://github.com/v4hn/%{name}/archive/v%{version}.tar.gz BuildArch: noarch Requires: dmenu +Requires: git +# The default editor Requires: vim-minimal +Requires: xterm %description %{summary}. @@ -27,5 +30,8 @@ %{_bindir}/snotes* %changelog +* Thu Feb 14 2013 Petr Šabata <contyk@xxxxxxxxxx> - 1.0-2 +- Add some forgotted runtime dependecies + * Wed Feb 13 2013 Petr Šabata <contyk@xxxxxxxxxx> - 1.0-1 - Initial package > FIX: Run-require `git' (snotes:49). +Requires: git Ok. > TODO: Run-require `xterm'. This the similar to already run-required `vim-minimal' (snotes:30). +Requires: xterm Ok. $ rpmlint snotes.spec ../SRPMS/snotes-1.0-2.fc19.src.rpm ../RPMS/noarch/snotes-1.0-2.fc19.noarch.rpm snotes.noarch: W: no-manual-page-for-binary snotes snotes.noarch: W: no-manual-page-for-binary snotes-open 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/snotes-1.0-2.fc19.noarch.rpm | sort | uniq -c 1 /bin/sh 1 dmenu 1 git 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 vim-minimal 1 xterm Binary requires are Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4969543). Ok. Package is good. Resolution: Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LPfXjjUG3X&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review