Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910835 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 782547cc4db6591d9db015eac49062e62837b2bd4bc4bdaa358a60e268081242). Ok. FIX: Run-require `git' (snotes:49). perl is optional. Ok. TODO: Run-require `xterm'. This the similar to already run-required `vim-minimal' (snotes:30). $ rpmlint snotes.spec ../SRPMS/snotes-1.0-1.fc19.src.rpm ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm snotes.noarch: W: no-manual-page-for-binary snotes snotes.noarch: W: no-manual-page-for-binary snotes-open 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm -rwxr-xr-x 1 root root 5028 Feb 14 09:20 /usr/bin/snotes -rwxr-xr-x 1 root root 2793 Feb 14 09:20 /usr/bin/snotes-open drwxr-xr-x 2 root root 0 Feb 14 09:20 /usr/share/doc/snotes-1.0 -rw-r--r-- 1 root root 1089 Feb 11 20:35 /usr/share/doc/snotes-1.0/LICENSE -rw-r--r-- 1 root root 773 Feb 11 20:35 /usr/share/doc/snotes-1.0/README File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm | sort | uniq -c 1 /bin/sh 1 dmenu 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 vim-minimal FIX: Run-require git TODO: Run-require xterm. $ rpm -q --provides -p ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm | sort | uniq -c 1 snotes = 1.0-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4969472). Ok. Otherwise package is in line with Fedora packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VGq10K6IMv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review