Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #11 from Simone Caronni <negativo17@xxxxxxxxx> --- A few issues before building: 1) gcab has renamed the library to libgcab1-devel; so that should be used as BuildRequires. 2) Line 52; please avoid the %make_install macro. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used 3) Change the subpackages names from libmsi-1.0* to something else (like libmsi1*, as MA Lureau did for gcab) as the "." character is not valid with package names. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators 4) Remove the Group tag from line 26 and 35 as they are needed only for EPEL5. 5) Line 37 should be removed, requirements for the correct shared library are added automatically when building. 6) Please sort the BuildRequires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m8KVgamARx&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review