Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910891 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |a.badger@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- 70c846c207c85d4a2dfbf2d3990e167767fed9db192353c7f068c653731e6b0b subprocess32-3.2.3.tar.gz Good: * package named appropriately * spec name meets guidelines * license is correct and approved * LICENSE file is included * Spec file is legible * Source matches upstream * Builds in koji * No locale files * Not a shared library * No bundled libraries * Not relocatable * Package owns all files and directories it creates and none that other packages create * No files listed twice * Permissions set properly * Macros used consistently * Code, not content * No large docs * Nothing in %doc affects runtime * Not a GUI app * All filenames valid UTF-8 * No scriptlets * No subpackages rpmlint: * All spelling warnings and they are all false positives. Cosmetic: * Doesn't need -O1 in "%{__python} setup.py install -O1: APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LQjug6GBpU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review