Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910481 nucleo <alekcejk@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alekcejk@xxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from nucleo <alekcejk@xxxxxxxxxxxxxx> --- This description from bomber.desktop will be more informative than "A single player arcade game" Summary: Arcade Bombing Game All sources in src are under "GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version". Documentation in doc licensed with "GNU Free Documentation License". Documentation say that "This program is licensed under the terms of the GNU General Public License." but actual sources license is LGPLv2+. So license tag should be License: LGPLv2+ and GFDL There are no GPLv2+ files, so license included in %doc should be COPYING.LIB and COPYING.DOC. Also README.themes can be added in %doc. rpmlint say "bomber.spec:66: W: macro-in-comment %{name}" so this line can be removed #{_kde4_configdir}/%{name}* -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fcsccpW1kh&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review