Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #4 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- Thanks for the review! :) > Now we'll have as many command line parsing Node.js libraries > in the distro as there are in the Python standard library! :-p Heh :P > Please package the latest version or provide a rationale for > packaging an older version. I have no rationale for packaging an older version other than "oops". Updated! (And now with an extra dep on nodejs-keypress: https://bugzilla.redhat.com/show_bug.cgi?id=910567 .) > Good (will look at dep generator to figure out what's causing > that trailing dot but it doesn't hurt anything and it's not your > problem. ;-) The package.json wants node >= 0.6.x so that's where the problem lies. I've added a patch for that in the spec but once the dep generator is fixed then I'll remove it. diff -Naur a/package.json b/package.json --- a/package.json +++ b/package.json @@ -9,5 +9,5 @@ , "devDependencies": { "should": ">= 0.0.1" } , "scripts": { "test": "make test" } , "main": "index" - , "engines": { "node": ">= 0.6.x" } + , "engines": { "node": ">= 0.6.0" } } > Please also document how the Source1 (tests) tarball is generated Done. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-commander.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-commander-1.1.1-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HXcvCLKquI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review