Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GDAL - Geospatial Data Abstraction Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222042 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-25 11:03 EST ------- Well, for -8: * rpmlint - some rpmlint complaint: ------------------------------------------------------- E: gdal-debuginfo script-without-shebang /usr/src/debug/gdal-1.4.0/alg/gdal_tps.cpp W: gdal-debuginfo spurious-executable-perm /usr/src/debug/gdal-1.4.0/frmts/jpeg/gdalexif.h ------------------------------------------------------- perhaps permisson issue * python scripts in %{_bindir} - byte-compiled files are not needed and please %exclude them. ("Unnecessary Byte compilation" section of http://fedoraproject.org/wiki/Packaging/Python ) * man files triage - Please "triage" man files according to the corresponding binaries. It seems that some man files should be installed in -python subpackage. * License - LGPL codes seem to be included -------------------------------------------------------- ./ogr/ogrsf_frmts/ili/iom/LICENSE.lgpl (and around this file) ./ogr/ogrsf_frmts/shape/LICENSE.LGPL (and around this file) ./pymod/gdal2xyz.py (and around this file) ./pymod/samples/histrep.py -------------------------------------------------------- - Note: not used for fedora package, however having different license: -------------------------------------------------------- ./swig/php/php_osr.h (and around this file) - PHP 2.02 -------------------------------------------------------- - Well, there are lots of "TO_RESOLVE" issues written on PROVENANCE.TXT. We can leave as it is expecting that upstream would solve these issues?? Especially, the license of the files under ./data is unclear. * ogdi - As ogdi passed the review, would you enable ogdi again? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review