[Bug 907756] Review Request: cloud-utils - cloud image management utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907756

--- Comment #13 from Juerg Haefliger <juergh@xxxxxxxxx> ---
Changes per reviewers comments and requests.

Spec URL:
http://juergh.fedorapeople.org/review/cloud-utils-0.27-0.2.bzr216.fc19/cloud-utils.spec
SRPM URL:
http://juergh.fedorapeople.org/review/cloud-utils-0.27-0.2.bzr216.fc19/cloud-utils-0.27-0.2.bzr216.fc19.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4952868


Spec file diff:

diff --git a/cloud-utils.spec b/cloud-utils.spec
index dbdedb7..567c18c 100644
--- a/cloud-utils.spec
+++ b/cloud-utils.spec
@@ -1,16 +1,16 @@
 Summary:       Cloud image management utilities
 Name:          cloud-utils
 Version:       0.27
-Release:       0.1.bzr216%{?dist}
+Release:       0.2.bzr216%{?dist}
 License:       GPLv3
 Group:         System Environment/Base
 URL:           https://launchpad.net/cloud-utils

 # bzr export -r 216 cloud-utils-0.27-bzr216.tar.gz lp:cloud-utils
 Source0:       %{name}-%{version}-bzr216.tar.gz
+Source1:        LICENSE

 BuildArch:     noarch
-BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 Requires:      gawk
 Requires:      gdisk
@@ -19,7 +19,8 @@ Requires:     euca2ools
 Requires:      file
 Requires:      python
 Requires:      python-paramiko
-Requires:      util-linux-ng
+Requires:      qemu-img
+Requires:      util-linux

 %description
 This package provides a useful set of utilities for managing cloud images.
@@ -32,31 +33,39 @@ The tasks associated with image bundling are often tedious
and repetitive. The
 cloud-utils package provides several scripts that wrap the complicated tasks
 with a much simpler interface.

+
 %prep
 %setup -q -n %{name}-%{version}-bzr216

+
 %build

+
 %install
-rm -rf $RPM_BUILD_ROOT
+cp %{SOURCE1} LICENSE

 # Install binaries
 mkdir -p $RPM_BUILD_ROOT/%{_bindir}
 cp bin/* $RPM_BUILD_ROOT/%{_bindir}/
+# Exclude Ubuntu-specific tools
+rm $RPM_BUILD_ROOT/%{_bindir}/*ubuntu*

 # Install man pages
 mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1
 cp man/* $RPM_BUILD_ROOT/%{_mandir}/man1/

-%clean
-rm -rf $RPM_BUILD_ROOT

 %files
-%defattr(-,root,root,-)
-%doc ChangeLog debian/copyright
+%doc ChangeLog LICENSE
 %{_bindir}/*
 %doc %{_mandir}/man1/*

+
 %changelog
+* Wed Feb 12 2013 Juerg Haefliger <juergh@xxxxxxxxx> - 0.27-0.2.bzr216
+- Add GPL-3 license.
+- Exclude Ubuntu-specific tools.
+- Fix some spec file issues per reviewers comments.
+
 * Tue Feb  5 2013 Juerg Haefliger <juergh@xxxxxxxxx> - 0.27-0.1.bzr216
 - Initial build based on upstream revision bzr216.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KcTRlvBgar&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]