Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> --- * Package name correct * Soruce tarball creation properly commented on * License correct and allowed in fedora * Spec file clean and legible * Builds fine in mock 1.) Newer version (3.0.15) is available 2.) Description is not accurate You speak of gtk3 theme, but ship theme for metacity and gtk2. Are those needed at all? 3.) Requires/provides might need tweaking: see below Would you mind splitting the themes into subpackages as is done for other theme packages (e.g. zukini), so that you'll have: clearlooks-phenix-gtk2-theme clearlooks-phenix-gtk3-theme clearlooks-phenix-xfwm4-theme clearlooks-phenix-metacity-theme clearlooks-phenix-openbox-theme clearlooks-phenix-common You'll be able to fix up the dependency chain then (e.g. not requiring clearlooks gtk2 engine when user only needs gtk3). Also, you'd be able to add missing Requires (of metacity or gtk+ itself) while not being afraid of dragging in unnecessary packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yUkJFOHgen&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review