Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826 ------- Additional Comments From pertusus@xxxxxxx 2007-02-25 07:40 EST ------- * %description is right (even a bit too long now ;-). It should be cut at about 80 columns. s/conviniently/conveniently/ s;Try to $HOME/.chmsee ;Try to remove $HOME/.chmsee; * I think that the chmsee-icon.png file should be kept in pixmaps, even though it is also in the theme directory. * in $RPM_BUILD_ROOT/%{_datadir}, / is unuseful. * you should keep timestamps when installing data files, adding -p to install call. * What about my proposal, using the same file for /usr/share/icons/gnome/48x48/mimetypes/gnome-mime-application-x-chm.png It seems to me that the file used should be a file specific of the file type, not a file corresponding with an application. Therefore the file chmfile.png from gnochm seems a better candidate to me than chmsee-icon.png. As a side note, I don't like that much that icon file, I prefer the ones that are with xchm, I find them better looking, and there are different sizes (and they are installed in the hicolor mimetype theme). However for the gnome theme it seems to me that an icon from a gnome/gtk package is better. * Suggestion: use your real name in changelog -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review