Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907007 Luke Benstead <kazade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kazade@xxxxxxxxx --- Comment #2 from Luke Benstead <kazade@xxxxxxxxx> --- A couple of comments: 1. We need to add a pkg-config file to the devel package. It should be called unittest++.pc and be installed to /usr/share/pkgconfig. I think the content should be something like this (although I'm not sure about the version) the name must be unittest++ otherwise programs won't be able to locate the library with pkg-config: # pkg-config source file prefix=/usr exec_prefix=${prefix} libdir=${exec_prefix}/lib includedir=${prefix}/include Name: unittest++ Description: unittest++ is a unit testing framework for C++ Version: 1.4.0 Requires: Conflicts: Libs: -L${libdir} -lUnitTest++ Cflags: -I${includedir}/unittest-cpp 2. The include directory is /usr/include/unittest-cpp rather than /usr/include/unittest++. It seems a bit odd for the library to be libUnitTest++.so and the folder to be unittest-cpp -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=efXDH4bljd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review