Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895667 --- Comment #8 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- The upstream thread I asked for information is http://forum.polymake.org/viewtopic.php?f=9&t=310 Result of a newer run: ---%<--- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Large documentation must go in a -doc subpackage. Note: Documentation size is 2969600 bytes in 32 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [?]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package devel, %package doc [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/pcpa/895667-polymake/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [!]: Large documentation must go in a -doc subpackage. Note: Documentation size is 2969600 bytes in 32 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Reguires:. [-]: CPAN urls should be non-versioned. Note: Test run failed ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [x]: SourceX / PatchY prefixed with %{name}. [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5191680 bytes in /usr/share 2242560 polymake-2.12-3.fc19.x86_64.rpm 2938880 polymake- doc-2.12-3.fc19.x86_64.rpm 10240 polymake-devel-2.12-3.fc19.x86_64.rpm Rpmlint ------- Checking: polymake-devel-2.12-3.fc19.x86_64.rpm polymake-debuginfo-2.12-3.fc19.x86_64.rpm polymake-2.12-3.fc19.src.rpm polymake-doc-2.12-3.fc19.x86_64.rpm polymake-2.12-3.fc19.x86_64.rpm polymake-devel.x86_64: W: no-documentation polymake-devel.x86_64: E: rpath-in-buildconfig /usr/bin/polymake-config lines ['150'] polymake-devel.x86_64: W: no-manual-page-for-binary polymake-config polymake.src: W: spelling-error Summary(en_US) polytopes -> polytheist polymake.src: W: spelling-error Summary(en_US) polyhedra -> polyhedral, polyhedron polymake.src: W: spelling-error %description -l en_US combinatorics -> combinations polymake.src: W: spelling-error %description -l en_US polytopes -> polytheist polymake.src: W: spelling-error %description -l en_US polyhedra -> polyhedral, polyhedron polymake.src: W: spelling-error %description -l en_US simplicial -> simplicity, simplistic polymake.src: W: spelling-error %description -l en_US matroids -> mastoids polymake.src: W: spelling-error %description -l en_US azove -> above, Azov polymake.src: W: spelling-error %description -l en_US gfan -> fan, fang, gran polymake.src: W: spelling-error %description -l en_US integrale -> integral, integrals, integrate polymake.src: W: spelling-error %description -l en_US normaliz -> normalize, normalization, normal polymake.src: W: spelling-error %description -l en_US ocaml -> Occam polymake.src: W: spelling-error %description -l en_US tplib -> split polymake.src: W: spelling-error %description -l en_US qhull -> hull, q hull, Hull polymake.src: W: spelling-error %description -l en_US vinci -> vincible polymake.src: W: spelling-error %description -l en_US geomview -> geom view, geom-view, overview polymake.src: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic polymake.src: W: spelling-error %description -l en_US gv -> g, v, gov polymake.src: W: spelling-error %description -l en_US okular -> ocular, ovular polymake.x86_64: W: spelling-error Summary(en_US) polytopes -> polytheist polymake.x86_64: W: spelling-error Summary(en_US) polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US combinatorics -> combinations polymake.x86_64: W: spelling-error %description -l en_US polytopes -> polytheist polymake.x86_64: W: spelling-error %description -l en_US polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US simplicial -> simplicity, simplistic polymake.x86_64: W: spelling-error %description -l en_US matroids -> mastoids polymake.x86_64: W: spelling-error %description -l en_US azove -> above, Azov polymake.x86_64: W: spelling-error %description -l en_US gfan -> fan, fang, gran polymake.x86_64: W: spelling-error %description -l en_US integrale -> integral, integrals, integrate polymake.x86_64: W: spelling-error %description -l en_US normaliz -> normalize, normalization, normal polymake.x86_64: W: spelling-error %description -l en_US ocaml -> Occam polymake.x86_64: W: spelling-error %description -l en_US tplib -> split polymake.x86_64: W: spelling-error %description -l en_US qhull -> hull, q hull, Hull polymake.x86_64: W: spelling-error %description -l en_US vinci -> vincible polymake.x86_64: W: spelling-error %description -l en_US geomview -> geom view, geom-view, overview polymake.x86_64: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic polymake.x86_64: W: spelling-error %description -l en_US gv -> g, v, gov polymake.x86_64: W: spelling-error %description -l en_US okular -> ocular, ovular polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/core.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/matroid.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/tropical.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/graph.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/common.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/topaz.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/polytope.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/group.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/fan.so 5 packages and 0 specfiles checked; 1 errors, 49 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint polymake-doc polymake-debuginfo polymake polymake-devel [A[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[C[Kl polymake.x86_64: W: spelling-error Summary(en_US) polytopes -> polytheist polymake.x86_64: W: spelling-error Summary(en_US) polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US combinatorics -> combinations polymake.x86_64: W: spelling-error %description -l en_US polytopes -> polytheist polymake.x86_64: W: spelling-error %description -l en_US polyhedra -> polyhedral, polyhedron polymake.x86_64: W: spelling-error %description -l en_US simplicial -> simplicity, simplistic polymake.x86_64: W: spelling-error %description -l en_US matroids -> mastoids polymake.x86_64: W: spelling-error %description -l en_US azove -> above, Azov polymake.x86_64: W: spelling-error %description -l en_US gfan -> fan, fang, gran polymake.x86_64: W: spelling-error %description -l en_US integrale -> integral, integrals, integrate polymake.x86_64: W: spelling-error %description -l en_US normaliz -> normalize, normalization, normal polymake.x86_64: W: spelling-error %description -l en_US ocaml -> Occam polymake.x86_64: W: spelling-error %description -l en_US tplib -> split polymake.x86_64: W: spelling-error %description -l en_US qhull -> hull, q hull, Hull polymake.x86_64: W: spelling-error %description -l en_US vinci -> vincible polymake.x86_64: W: spelling-error %description -l en_US geomview -> geom view, geom-view, overview polymake.x86_64: W: spelling-error %description -l en_US graphviz -> graph viz, graph-viz, graphic polymake.x86_64: W: spelling-error %description -l en_US gv -> g, v, gov polymake.x86_64: W: spelling-error %description -l en_US okular -> ocular, ovular polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/core.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/matroid.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/tropical.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/graph.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/common.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/topaz.so polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::alloc_impl(int, bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::operator==(polymake::graph::BlissGraph const&) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::find_vertex_node(polymake::graph::HasseDiagram const&, int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::HasseDiagram::makeObject() const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::~BlissGraph() polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::add_edge(unsigned int, unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::operator>>(pm::perl::Value const&, polymake::graph::HasseDiagram&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::partition(unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::HasseDiagram::delete_node(int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::finalize(bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::BlissGraph::find_permutations(polymake::graph::BlissGraph const&, int) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/topaz.so polymake::graph::HasseDiagram::fromObject(pm::perl::Object const&) polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/polytope.so polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::group::correct_group_from_permlib_group(pm::perl::Object, polymake::group::PermlibGroup const&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::group::group_from_perlgroup(pm::perl::Object) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::find_permutations(polymake::graph::BlissGraph const&, int) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::color(unsigned int, unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::operator>>(pm::perl::Value const&, polymake::graph::HasseDiagram&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::add_edge(unsigned int, unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::finalize(bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::operator==(polymake::graph::BlissGraph const&) const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::HasseDiagram::makeObject() const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::alloc_impl(int, bool) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::HasseDiagram::fromObject(pm::perl::Object const&) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::partition(unsigned int) polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/polytope.so polymake::graph::BlissGraph::~BlissGraph() polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/group.so polymake.x86_64: W: no-soname /usr/lib64/polymake/lib/fan.so polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/fan.so polymake::graph::HasseDiagram::makeObject() const polymake.x86_64: W: undefined-non-weak-symbol /usr/lib64/polymake/lib/fan.so polymake::graph::operator>>(pm::perl::Value const&, polymake::graph::HasseDiagram&) polymake-devel.x86_64: W: no-documentation polymake-devel.x86_64: E: rpath-in-buildconfig /usr/bin/polymake-config lines ['150'] polymake-devel.x86_64: W: no-manual-page-for-binary polymake-config 4 packages and 0 specfiles checked; 1 errors, 57 warnings. # echo 'rpmlint-done:' Requires -------- polymake-devel-2.12-3.fc19.x86_64.rpm (rpmlib, GLIBC filtered): /usr/bin/perl libpolymake.so.2()(64bit) perl(strict) polymake(x86-64) = 2.12-3.fc19 polymake-debuginfo-2.12-3.fc19.x86_64.rpm (rpmlib, GLIBC filtered): polymake-doc-2.12-3.fc19.x86_64.rpm (rpmlib, GLIBC filtered): polymake(x86-64) = 2.12-3.fc19 polymake-2.12-3.fc19.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/perl libbliss.so.0()(64bit) libc.so.6()(64bit) libcdd.so.0()(64bit) libcddgmp.so.0()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) liblrsgmp.so.4()(64bit) libm.so.6()(64bit) libmpfr.so.4()(64bit) libperl.so()(64bit) libpolymake.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libsympol.so.0.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) perl >= 1:5.8.1 perl(:MODULE_COMPAT_5.16.2) perl(Carp) perl(Config) perl(Cwd) perl(DynaLoader) perl(Encode) perl(Errno) perl(Fcntl) perl(File::Path) perl(Getopt::Long) perl(IO::Handle) perl(IPC::Open3) perl(Math::Trig) perl(POSIX) perl(Socket) perl(Symbol) perl(Term::ReadLine) perl(XML::LibXML) perl(XML::SAX::Base) perl(XML::Writer) perl(integer) perl(lib) perl(overload) perl(re) perl(strict) perl(subs) perl(vars) rtld(GNU_HASH) Provides -------- polymake-devel-2.12-3.fc19.x86_64.rpm: polymake-devel = 2.12-3.fc19 polymake-devel(x86-64) = 2.12-3.fc19 polymake-debuginfo-2.12-3.fc19.x86_64.rpm: polymake-debuginfo = 2.12-3.fc19 polymake-debuginfo(x86-64) = 2.12-3.fc19 polymake-doc-2.12-3.fc19.x86_64.rpm: polymake-doc = 2.12-3.fc19 polymake-doc(x86-64) = 2.12-3.fc19 polymake-2.12-3.fc19.x86_64.rpm: libpolymake.so.2()(64bit) polymake = 2.12-3.fc19 polymake(x86-64) = 2.12-3.fc19 Unversioned so-files -------------------- polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/common.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/core.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/fan.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/graph.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/group.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/matroid.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/polytope.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/topaz.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/lib/tropical.so polymake-2.12-3.fc19.x86_64.rpm: /usr/lib64/polymake/perlx/5.16.2/x86_64-linux-thread-multi/auto/Polymake/Ext/Ext.so MD5-sum check ------------- http://polymake.org/lib/exe/fetch.php/download/polymake-2.12-rc3.tar.bz2 : CHECKSUM(SHA256) this package : 354a5220009882c178d8d98ec8c16921eea284ed73ff7d36c5fee787aa3f4796 CHECKSUM(SHA256) upstream package : 354a5220009882c178d8d98ec8c16921eea284ed73ff7d36c5fee787aa3f4796 Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -v -b 895667 -m fedora-rawhide-x86_64 ---%<--- I believe polymake-config should be patch to not add rpath: $ polymake-config --ldflags -L/usr/lib64 -Wl,-z,relro -Wl,--as-needed -Wl,-rpath,/usr/lib64 removing the unneeded -L%{_libdir} should also be a good idea as the rpm is not supposed to install libraries in a non standard directory. Otherwise, I belive the package looks good. Jerry, please run again fedora-review in the sagemath package :-) As of yesterday all issues were solved and fedora-review was working on the sagemath srpm. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m47fzaD7zY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review