Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909674 --- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Isaku: Is good practice paste the rpmlint output in the reviews http://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint and make scratch builds and paste the link in the review https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds - %clean is not needed - BuildRoot is not needed - cleaning of buildroot in %install is not needed - %defattr is not needed - The use of %define is deprecated - The tag license is wrong (in this case should be ASL 2.0) - The tag vendor not needed in Fedora - Don't repeat the name of the package in the summary, it's redundant - If the package contains conf files in /etc must marked as %config take a look at the rpmlint output will give a better explanation to what I'm saying After fixing these problems, you should take a look at: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Convincing_someone_to_sponsor_you Kind Regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=okDSYy7n69&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review