Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909387 --- Comment #2 from Frederik Holden <frederik+fedora@xxxxxx> --- (In reply to comment #1) > Note: I am on the way to become a packanger, so don't trust me to much maybe > i am wrong! Packager or no, I appreciate the input. > [!]: Large documentation must go in a -doc subpackage. > Note: Documentation size is 10455040 bytes in 453 files. The large documentation is actually split into a subpackage (devel-doc), but a fedora-review bug (bug 908830) shows this error anyway. This bug has been fixed in 0.4.0-3, which is currently in updates-testing. > [?]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package > devel-doc, %package devel I have not set up a the base package or the devel package as a requirement for devel-doc. It only contains documentation, and said documentation might be considered useful on its own. If this contracts Fedora policy or practice, I'd be happy to change it. > [?]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "GPL (unversioned/unknown version) LGPL (v2)", "GPL (v2 or later)", > "Unknown or generated". 3 files have unknown license. Detailed output of > licensecheck in /home/benedikt/909387-c++-gtk-utils/licensecheck.txt I am somewhat unsure of this myself. Everywhere I check on the SF page, it says that it's LGPLv2 licensed. I can contact upstream for clarification if needed. > [?]: License file installed when any subpackage combination is installed. The base package contains COPYING, and devel depends on the base package. devel-doc contains COPYING as well. > c++-gtk-utils-devel.x86_64: W: no-documentation Documentation is found in devel-doc. > c++-gtk-utils-devel.x86_64: W: spelling-error %description -l en_US toolkits > -> toolkit, tool kits, tool-kits > c++-gtk-utils.x86_64: W: spelling-error %description -l en_US gtkmm > c++-gtk-utils.x86_64: W: spelling-error %description -l en_US wxWidgets -> > widgets Not actual spelling errors. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wAT1iQTSGA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review