Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885409 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #10 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok 0d903468bb288c3c05030c36fa5a25c8 mate-applets-1.5.1.tar.xz build: ok (mostly) 1. SHOULD fix configure: WARNING: unrecognized options: --disable-timers-applet maybe you meant, --disable-timer-applet ? license: not ok 2. MUST fix License tag, checked with licencecheck, found all sources to be GPL (v2 or later), so please use License: GPLv2+ macros: ok scriptlets: ok build: not sure. tried local build, got a bunch of unpackaged files wrt mateweather and multiload applets. submitted scratch build to confirm: http://koji.fedoraproject.org/koji/taskinfo?taskID=4942825 4942825 build (f19, mate-applets-1.5.1-1.fc18.src.rpm) completed successfully ok, probably just a matter of some missing buildrequires for those extra applets, I'll leave it to you to decide if you want to include/package those or not. Meh, only one real blocker found, but largely cosmetic, so I'll leave it to you to fix prior to doing any official builds. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7PoBjOIjbX&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review