Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885317 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|rdieter@xxxxxxxxxxxx |extras-qa@xxxxxxxxxxxxxxxxx --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Some initial comments: 1. why hardcode python2.7 everywhere? like, %global __python %{__python}2.7 BuildRequires: python(abi) = 2.7 Either justify this, or remove it, and use simpler: BuildRequires: python2-devel or just BuildRequires: python-devel 2. MUST drop this, desktop-file-install \ --dir=${RPM_BUILD_ROOT}%{_kde4_datadir}/kde4/services/ \ --remove-key=Encoding \ --remove-key=Type \ --set-key=Type \ --set-value=Application \ ${RPM_BUILD_ROOT}/%{_kde4_datadir}/kde4/services/kdevpythonsupport.desktop .desktop file validation is only for stuff intended for gui menus (ie, stuff under /usr/share/appliations) 3. SHOULD omit: BuildRequires: cmake >= 2.6 (it's superfluous, pulled in already by kdelibs-devel down the stack a ways) scriptlets: NOT ok. 4. MUST drop: %post update-desktop-database &> /dev/null || : update-mime-database %{_datadir}/mime &> /dev/null || : %postun update-desktop-database &> /dev/null || : update-mime-database %{_datadir}/mime &> /dev/null || : this package neither provides app .desktop files with mimetype associations, nor defines it's own mimetype's, so these scriptlets aren't needed. 5. pkg includes shared library, MUST add scriptlet: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig 6. SHOULD replace %files references : %{_kde4_datadir}/kde4/apps/ with %{_kde4_appsdir}/ 7. MUST document what Patch0: kdevelop-python-documentation-files.patch is for. why is it needed? what does it fix? has it been upstreamed? if not, why not? naming: ok licensing: NOT ok, mixture of (at least): BSD, LGPLv2+, GPLv2+, GPLv3+ , 8. MUST update License: tag, corresponding to aggregate license (GPLv3+), License: GPLv3+ sources: ok 8980b2cdb955f8f34f7560ffc940ef1b kdev-python-v1.4.1.tar.bz2 So far so good, have a handful of issues to address. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oenfz4xRXZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review