Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895757 --- Comment #13 from Simone Caronni <negativo17@xxxxxxxxx> --- Easy issues, after fixing these for me the package is good to go: =============== [!]: License file installed when any subpackage combination is installed. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Just copy line 70 into the main gcab %files section. =============== [!]: Packages should try to preserve timestamps of original installed files. Add the "-p" switch to the "cp" command at line 55. =============== Rpmlint Checking: gcab-debuginfo-0.3-2.fc18.x86_64.rpm gcab-0.3-2.fc18.src.rpm gcab-0.3-2.fc18.x86_64.rpm gcab.src:88: W: macro-in-%changelog %{buildroot} 3 packages and 0 specfiles checked; 0 errors, 1 warnings. To add macros in changelog or comments you can use the double percentage, like: - Use %%{buildroot} consitantly. =============== Regarding tab/indentation; the spec file it's like it was before, can you please make all the lines with "Requires:", "Group:", etc. aligned like in lines 1-11? =============== Thanks! --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aPlaIeFysw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review