Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895757 --- Comment #10 from Simone Caronni <negativo17@xxxxxxxxx> --- Hello, sorry for being late, I've been quite busy. Before I proceed with the review, I would like to have a couple of things fixed on top of those: 1) Please format the file in a consistent way, the top part is tabbed the other subpackages are not. 2) Be consistent with %{buildroot} and $RPM_BUILD_ROOT; use one or the other. Please replace line 49 DESTDIR with %{buildroot}. 3) Change the subpackages names from libgcab-1.0* to something else (like libgcab-10*) as the "." character is not valid with package names [1]. 4) You can remove the comments after %configure. 5) Be consistent with the rpm version you want to build for. If you want to build for Fedora only please remove line 30; otherwise if you want to build also for el5 please add the missing tags in the spec file. I would be glad if you will build the package also for el5/el6 and I can offer myself as co-mantainer for those branches if you don't want the burden for those platform. To see the mising tags required for el5; run the following command: rpmdev-newspec -m -r 4.5 -o el5.spec 6) When updating the spec file for the review, please do not replace the original spec and rpm but bump the release tag. Thanks, --Simone [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=apakI5Trrz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review