Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ppisar@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: ed134dec1e0735af5a872a2ff299837d973e23cc83e2da3e468c63696f655d13). Ok. Summary verified from lib/Perl/Stripper.pm. Ok. Description verified from lib/Perl/Stripper.pm. Ok. License verified from LICENSE, lib/Perl/Stripper.pm, README. Ok. No XS code, noarch BuildArch is Ok. TODO: You can build-require `perl(vars)' for consistency (t/data/1.pl:4). Test::Script is optional. Ok. Test::Pod is not used. Ok. Test::Pod::Coverage is not used. Ok. Pod::Coverage::TrustPod is not used. Ok. All tests pass. Ok. $ rpmlint perl-Perl-Stripper.spec ../SRPMS/perl-Perl-Stripper-0.04-1.fc19.src.rpm ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Feb 7 17:50 /usr/share/doc/perl-Perl-Stripper-0.04 -rw-r--r-- 1 root root 366 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/Changes -rw-r--r-- 1 root root 18356 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/LICENSE -rw-r--r-- 1 root root 6467 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/README -rw-r--r-- 1 root root 4443 Feb 7 17:50 /usr/share/man/man3/Perl::Stripper.3pm.gz drwxr-xr-x 2 root root 0 Feb 7 17:50 /usr/share/perl5/vendor_perl/Perl -rw-r--r-- 1 root root 10787 Feb 7 17:50 /usr/share/perl5/vendor_perl/Perl/Stripper.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm | sort | uniq -c 1 perl >= 1:5.010 1 perl(Log::Any) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Moo) 1 perl(PPI) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Perl::Stripper) = 0.04 1 perl-Perl-Stripper = 0.04-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4936677). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=63cH6K50kg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review