Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895757 --- Comment #6 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxxx> --- (In reply to comment #5) > Some remarks: > > - Building is non-verbose. > Please append --disable-silent-rules to %configure to make it verbose. I don't see why this is necessary, but ok. Is there a policy about it? Imho, you can easily miss important gcc warnings in non-silence mode. > - Please append --disable-static to %configure. This avoids building the > static libs and speeds up building. ok, since we don't even ship it there (again, is there any policy?) > - Don't use %make_install. Instead use make DESTDIR=... install. > %make_install is an ancient relic which should not be used in new packages. Ah, ok. I suggest rpmbuild or fedpkg do this kind of checks and prints a warning... Also the emacs spec boilerplate is outdated then (emacs in f18) So fixing. > Furthermore: The rationale for --fast-install escapes me. Same here, that's why I tried to ask Paolo, who could be knowledgeable here :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qYUPWAigpV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review