Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886300 --- Comment #7 from François Cami <fdc@xxxxxxxxx> --- Hello Pavel! Thanks for your comments. :) * Requires: %{name}%{?_isa} = %{version}-%{release} => fixed. * ldconfig in posttrans => I think it is needed, see https://www.redhat.com/archives/rhl-devel-list/2007-June/msg02497.html for instance. * sinodisp had no documentation => hehe, no problem. :) * malloc.c => I am pretty sure it is not needed after looking at the sources. I am going to ask upstream to remove it from future releases. * long lines => split. * /usr/share/sino-3.1.21 not owned by any package => ooops, my bad. fixed. * explicit Requires: => added %{_isa} and a note. TODO: * sino / sinomake / sinoshow / sinodisp are statically linked => this requires building the shared library first, or relinking afterwards... Hmmm. Let me think about it, but I agree, I need to fix that. In the meantime: Spec URL: http://fcami.fedorapeople.org/srpms/sino.spec SRPM URL: http://fcami.fedorapeople.org/srpms/sino-3.1.21-4.fc18.src.rpm Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yDXmnDj5lo&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review