Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #28 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- (In reply to comment #27) > Gogui don't require gnugo > You can use GoGui without any Go engine as a SGF viewer/editor or as a > local Go board for playing games between humans. > However its main use is as a GUI for Go engines so i have include a new > patch who add a second desktop for gnugo if he is installed. I don't think this patch is a good idea, unless you explicitely set gnugo as a Requires. What would happen if I launched gogui through this new desktop entry, without having gnugo installed? Such a patch is probably superfluous for gogui. The description of gogui is clear enough to imply it's GTP client, after all. By the way, as I told you several weeks ago on IRC, please use macros provided by jpackage-utils to generate executable wrappers: https://fedoraproject.org/wiki/Packaging:Java#Wrapper_Scripts To my opinion, it's safer and easier to maintain than patching the launcher scripts provided upstream with complicated sed queries. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mskMjKjT2b&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review