Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #2 from Michael Scherer <misc@xxxxxxxx> --- A few remark : - %%doc %{gem_instdir}/README.txt why a %% instead of % ? - URL: http://devcentral.f5.com/ The url seems wrong - there is no license shipped - Licensing is wrong : # This program is copyrighted free software by NAKAMURA, Hiroshi. You can # redistribute it and/or modify it under the same terms of Ruby's license; # either the dual license version in 2003, or any later version. that's not GPLv2 ( and I think there is some license mixing ) - this is likely wrong find %{buildroot}/%{gem_instdir} -type f -exec sed -r -e 's"^#!(.*)/usr/bin/env ruby"#!/usr/bin/ruby"' {} \; as it print on stdout the fixed file, you may miss a -i ( see the build.log file ) - the gem ship its own CA store ( /usr/share/gems/gems/httpclient-2.3.2/lib/httpclient/cacert.p7s ). This may include outdated certificates ( as it get them from jdk, I would not bet on their security ), and i do not know how to check. And of course, it use it by default :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3j1Ean9fWr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review