Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openjpeg - JPEG 2000 codec library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098 ------- Additional Comments From seg@xxxxxxxxxx 2007-02-23 19:10 EST ------- Sorry, I got tied up with other things. Updated package: http://www.haxxed.com/rpms/secondlife/openjpeg-1.1-2.src.rpm http://www.haxxed.com/rpms/secondlife/openjpeg.spec * Sat Feb 17 2007 Callum Lerwick <seg@xxxxxxxxxx> 1.1-2 - Move header to a subdirectory. - Fix makefile patch to preserve timestamps during install. I hate using macros unless there's a really good reason. The package name is very unlikely to change, and on the rare occasion that it might, a search and replace isn't a big deal. So I avoid using %{name} The no-doc warning on the devel package is ignoreable. The main package has docs. Hmmm, I actually need to go over the docs, README.linux shouldn't be packaged and ChangeLog might be better in the devel package. And where's the license... I figure the purpose of the makefile patch is self evident, based on the name and by taking a look at it. I put in a comment for the others because otherwise it would not be clear that they're there for the benefit of another package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review