Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: be17fbc945c8ab3faac8870bed99704c023919863e583c56b43e9df05ef7a39a). Ok. Summary verified from lib/Data/Validate/Domain.pm. Ok. Description verified from lib/Data/Validate/Domain.pm. Ok. License verified from lib/Data/Validate/Domain.pm, and README. Ok. No XS code, noarch BuildArch is Ok. TODO: Qualify `perl(Net::Domain::TLD)' build- and run-requirement with `>= 1.62' constraint (META.yml:12). Test::Pod::Coverage is optional. Ok. Test::Pod is optional. Ok. All tests pass. Ok. $ rpmlint perl-Data-Validate-Domain.spec ../SRPMS/perl-Data-Validate-Domain-0.10-1.fc19.src.rpm ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm perl-Data-Validate-Domain.src: W: spelling-error %description -l en_US untainting -> tainting, unstinting, taunting perl-Data-Validate-Domain.src: W: spelling-error %description -l en_US undef -> unfed, under, funded perl-Data-Validate-Domain.src: W: spelling-error %description -l en_US username -> user name, user-name, surname perl-Data-Validate-Domain.noarch: W: spelling-error %description -l en_US untainting -> tainting, unstinting, taunting perl-Data-Validate-Domain.noarch: W: spelling-error %description -l en_US undef -> unfed, under, funded perl-Data-Validate-Domain.noarch: W: spelling-error %description -l en_US username -> user name, user-name, surname 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Feb 5 17:20 /usr/share/doc/perl-Data-Validate-Domain-0.10 -rw-r--r-- 1 root root 2231 Dec 29 2010 /usr/share/doc/perl-Data-Validate-Domain-0.10/Changes -rw-r--r-- 1 root root 9026 May 16 2007 /usr/share/doc/perl-Data-Validate-Domain-0.10/README -rw-r--r-- 1 root root 4734 Feb 5 17:20 /usr/share/man/man3/Data::Validate::Domain.3pm.gz drwxr-xr-x 2 root root 0 Feb 5 17:20 /usr/share/perl5/vendor_perl/Data drwxr-xr-x 2 root root 0 Feb 5 17:20 /usr/share/perl5/vendor_perl/Data/Validate -rw-r--r-- 1 root root 11838 Dec 29 2010 /usr/share/perl5/vendor_perl/Data/Validate/Domain.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Net::Domain::TLD) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Data::Validate::Domain) = 0.10 1 perl-Data-Validate-Domain = 0.10-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4930421). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2BYzH4X3SD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review