Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=844621 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 68f62f269ffbbb430daa1c78f1459ad733cacda9fed63b0d048c4b5ae2c00cdc). Ok. Summary verified from META.yml. Ok. Description verified from lib/Log/Contextual.pm. Ok. License verified from lib/Log/Contextual.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: You can use DESTDIR argument instead of PERL_INSTALL_ROOT in %install section. Log::Log4perl is optional. Ok. TODO: Remove useless build-require `perl(ExtUtils::MakeMaker)'. All occurrences are in removed inc/. FIX: Remove useless build-require `perl(Test::Fatal)'. It's not used anywhere. FIX: Build-require `perl(Exporter::Declare::Export::Generator)' (lib/Log/Contextual.pm:11). All tests pass. Ok. $ rpmlint perl-Log-Contextual.spec ../SRPMS/perl-Log-Contextual-0.004300-1.fc19.src.rpm ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm perl-Log-Contextual.spec: E: specfile-error warning: bogus date in %changelog: Tue Jul 21 2012 Jitka Plesnikova <jplesnik@xxxxxxxxxx> - 0.004201-1 perl-Log-Contextual.src: W: spelling-error %description -l en_US SimpleLogger -> Simple Logger, Simple-logger, Oversimple perl-Log-Contextual.src: W: spelling-error %description -l en_US Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli perl-Log-Contextual.src: E: specfile-error warning: bogus date in %changelog: Tue Jul 21 2012 Jitka Plesnikova <jplesnik@xxxxxxxxxx> - 0.004201-1 perl-Log-Contextual.noarch: W: spelling-error %description -l en_US SimpleLogger -> Simple Logger, Simple-logger, Oversimple perl-Log-Contextual.noarch: W: spelling-error %description -l en_US Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli 2 packages and 1 specfiles checked; 2 errors, 4 warnings. FIX: Use valid date in changelog entry. $ rpm -q -l -v -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Feb 5 15:27 /usr/share/doc/perl-Log-Contextual-0.004300 -rw-r--r-- 1 root root 1763 Oct 4 00:18 /usr/share/doc/perl-Log-Contextual-0.004300/Changes -rw-r--r-- 1 root root 7061 Feb 5 15:27 /usr/share/man/man3/Log::Contextual.3pm.gz -rw-r--r-- 1 root root 3020 Feb 5 15:27 /usr/share/man/man3/Log::Contextual::SimpleLogger.3pm.gz -rw-r--r-- 1 root root 3017 Feb 5 15:27 /usr/share/man/man3/Log::Contextual::TeeLogger.3pm.gz -rw-r--r-- 1 root root 3447 Feb 5 15:27 /usr/share/man/man3/Log::Contextual::WarnLogger.3pm.gz drwxr-xr-x 2 root root 0 Feb 5 15:27 /usr/share/perl5/vendor_perl/Log drwxr-xr-x 2 root root 0 Feb 5 15:27 /usr/share/perl5/vendor_perl/Log/Contextual -rw-r--r-- 1 root root 18150 Oct 4 00:17 /usr/share/perl5/vendor_perl/Log/Contextual.pm -rw-r--r-- 1 root root 3587 Aug 9 2012 /usr/share/perl5/vendor_perl/Log/Contextual/SimpleLogger.pm -rw-r--r-- 1 root root 3210 Aug 9 2012 /usr/share/perl5/vendor_perl/Log/Contextual/TeeLogger.pm -rw-r--r-- 1 root root 6041 Aug 9 2012 /usr/share/perl5/vendor_perl/Log/Contextual/WarnLogger.pm File layout and permissions are Ok. $ rpm -q -l --requires -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Data::Dumper::Concise) 1 perl(Exporter::Declare) 1 perl(Exporter::Declare) >= 0.105 1 perl(Exporter::Declare::Export::Generator) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/share/doc/perl-Log-Contextual-0.004300 1 /usr/share/doc/perl-Log-Contextual-0.004300/Changes 1 /usr/share/man/man3/Log::Contextual.3pm.gz 1 /usr/share/man/man3/Log::Contextual::SimpleLogger.3pm.gz 1 /usr/share/man/man3/Log::Contextual::TeeLogger.3pm.gz 1 /usr/share/man/man3/Log::Contextual::WarnLogger.3pm.gz 1 /usr/share/perl5/vendor_perl/Log 1 /usr/share/perl5/vendor_perl/Log/Contextual 1 /usr/share/perl5/vendor_perl/Log/Contextual.pm 1 /usr/share/perl5/vendor_perl/Log/Contextual/SimpleLogger.pm 1 /usr/share/perl5/vendor_perl/Log/Contextual/TeeLogger.pm 1 /usr/share/perl5/vendor_perl/Log/Contextual/WarnLogger.pm TODO: Do not require unversioned `perl(Exporter::Declare)'. $ rpm -q -l --provides -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Log::Contextual) = 0.004300 1 perl-Log-Contextual = 0.004300-1.fc19 1 perl(Log::Contextual::SimpleLogger) 1 perl(Log::Contextual::TeeLogger) 1 perl(Log::Contextual::WarnLogger) 1 /usr/share/doc/perl-Log-Contextual-0.004300 1 /usr/share/doc/perl-Log-Contextual-0.004300/Changes 1 /usr/share/man/man3/Log::Contextual.3pm.gz 1 /usr/share/man/man3/Log::Contextual::SimpleLogger.3pm.gz 1 /usr/share/man/man3/Log::Contextual::TeeLogger.3pm.gz 1 /usr/share/man/man3/Log::Contextual::WarnLogger.3pm.gz 1 /usr/share/perl5/vendor_perl/Log 1 /usr/share/perl5/vendor_perl/Log/Contextual 1 /usr/share/perl5/vendor_perl/Log/Contextual.pm 1 /usr/share/perl5/vendor_perl/Log/Contextual/SimpleLogger.pm 1 /usr/share/perl5/vendor_perl/Log/Contextual/TeeLogger.pm 1 /usr/share/perl5/vendor_perl/Log/Contextual/WarnLogger.pm Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4930081). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0ZXmU5Akal&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review