Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887778 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #693385| |review+ Flags| | --- Comment #7 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Created attachment 693385 --> https://bugzilla.redhat.com/attachment.cgi?id=693385&action=edit remaining spec issues APPROVED Here are comments on a few last issues, which need not be fixed with another src.rpm, but can be fixed when/after importing into Fedora package git: * The "rm -fr %{buildroot}/glib-compatible/pcre" after %prep effectively is a no-op, because %buildroot doesn't exist at that time yet. And to delete files from the extracted source archive, it would need to happen _after_ %setup, not before it. That's why I moved %setup a few lines in the attached patch. However, I had to comment out the "rm -rf …" line, because one cannot simply remove the directory, because that breaks the build very early (missing the Makefile.in template) or (if only removing the source files) very late during %check: Making check in po make[1]: Entering directory `/home/personal/tmp/rpm/BUILD/cutter-1.2.2/po' make[1]: *** No rule to make target `../glib-compatible/pcre/pcre_chartables.c', needed by `cutter.pot'. Stop. make[1]: Leaving directory `/home/personal/tmp/rpm/BUILD/cutter-1.2.2/po' make: *** [check-recursive] Error 1 So, with regard to the unbundling policy, it's okay if you ensure that the included PCRE is not built with in favour of the system lib. * "%dir %{_libdir}/gstreamer-0.10" is owned by the "gstreamer" package already, which cutter-gstreamer depends on automatically via libraries. * rpmbuild for Fedora 19 development notices a few "bogus date" warnings in the %changelog, which I've corrected with the help of "date -d …". -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8g63La11z0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review