[Bug 906248] Review Request: libkkc - Japanese Kana Kanji conversion library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=906248

--- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-
+ Koji scratch build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=4929607

+ rpmlint on rpms gave
libkkc.src: W: spelling-error %description -l en_US kkc -> kc, k kc, KC
libkkc.src: W: spelling-error %description -l en_US el -> e, l, eel
libkkc.x86_64: W: spelling-error %description -l en_US kkc -> kc, k kc, KC
libkkc.x86_64: W: spelling-error %description -l en_US el -> e, l, eel
libkkc-data.x86_64: W: no-documentation
libkkc-devel.x86_64: W: no-documentation
libkkc-tools.x86_64: W: no-documentation
libkkc-tools.x86_64: W: no-manual-page-for-binary kkc
6 packages and 0 specfiles checked; 0 errors, 8 warnings.

+ Source verified with upstream as
https://bitbucket.org/libkkc/libkkc/downloads/libkkc-0.1.2.tar.gz :
  CHECKSUM(SHA256) this package     :
885c34780b8f5318bb8a4276e6f331fad37f020442d5f720dfea75da3f100da6
  CHECKSUM(SHA256) upstream package :
885c34780b8f5318bb8a4276e6f331fad37f020442d5f720dfea75da3f100da6
https://bitbucket.org/libkkc/libkkc-data/downloads/libkkc-data-0.1.1.tar.gz :
  CHECKSUM(SHA256) this package     :
eeaaf2a4dfc9e051da044874169be5385d2cd4f2a0785b1de705d9955f3f10dc
  CHECKSUM(SHA256) upstream package :
eeaaf2a4dfc9e051da044874169be5385d2cd4f2a0785b1de705d9955f3f10dc

+ License is GPLv3+  and included in COPYING as well as some source files in
libkkc tarball


Suggestions:
1) you can add ChangeLog from data tarball to -data as %doc

2) I see that -data installing just models and keymaps. This should be noarch
package then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FrWRjXvtz4&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]