Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889011 --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Hi Dan, * Could you please consider to simplify the install section a bit? Two copy commands should be enough (if there is no special reason): mkdir -p %{buildroot}%{gem_dir} cp -pa .%{gem_dir}/* \ %{buildroot}%{gem_dir}/ mkdir -p %{buildroot}%{_bindir} cp -pa .%{_bindir}/* \ %{buildroot}%{_bindir}/ and then you can exclude the gem cache in files section using: %exclude %{gem_cache} * Could you please remove the Requires: ruby - Unless you know that the gem is compatible just with MRI, it would be nice if you could drop the ruby dependency, since we are going to add support for JRuby in F19. * I observe several test failures running the build on F19, could you please check them? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=89CFzuIyhR&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review