[Bug 885344] Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885344

Shawn Iwinski <siwinski@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |siwinski@xxxxxxxxxx

--- Comment #8 from Shawn Iwinski <siwinski@xxxxxxxxxx> ---
(In reply to comment #7)
> MUST:
> 
> [!]: Package contains no bundled libraries.
> 	provides ...Guzzle/Http/Resources/cacert.pem
> 	should use /etc/pki/tls/cert.pem
> 	(ca-certificates on fedora, need to check on RHEL)
> 	See https://fedoraproject.org/wiki/Features/SharedSystemCertificates
> 
> 	In source code Guzzle/Http/Client.php
> 	 $opts[CURLOPT_CAINFO] = __DIR__ . '/Resources/cacert.pem'
> 	This will obviously not work, with current version
> 	(should use data_dir).
> 
> 	(this is not a library, but for security reason, using
> 	a bundled copy seems a very bad idea)

Removed bundled cert


> SHOULD: 
> 
> [!]: Latest version is packaged.
> 	3.1.2 is released

Updated to 3.1.2


> [!]: %check is present and all tests pass.
> 	as tests exists in upstream github, please
> 	ask upstream to include them in the tarball

Will work with upstream to get tests included in PEAR package.



Spec URL:
http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-guzzle-Guzzle.spec

SRPM URL:
http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-guzzle-Guzzle-3.1.2-1.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OH78H1qRkB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]