[Bug 894725] Review Request: uglify-js - JavaScript parser, mangler/compressor and beautifier toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894725

--- Comment #18 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
(In reply to comment #17)
> (In reply to comment #16)
> > I am afraid that the -common package does not contain the uglifyjs
> > executable, so it is worthless for rubygem-uglifier purposes.
> 
> I can probably accommodate this, but I can't figure out where
> rubygem-uglifier actually uses it.  It doesn't appear to bundle it.

You might be right, the executable might be excluded. I have never dug into it
in detail. Not sure what is ouptut of `./vendor/uglifyjs/bin/uglifyjs --self
--comments /Copyright/` since this is what is embedded in uglifier.

> If you can point me to Ruby code that calls it in, that would be helpful.

This is the exec script [1], which probably substitutes the binary and this [2]
is how options are passed in, i.e. they are substituted for %s in the script.

> > Moreover, the uglifier gem contains just single uglify.js file, which
> > probably contains all the uglifyjs files. Not sure how to cope with that. If
> > linking will be enough.
> 
> Looking at the Rakefile [1], it seems that it bundles source-map and
> uglify-js by compiling them both into one .js file.

Right.

> There is no bundled
> libraries exception for JavaScript not in the browser, so I don't think this
> is permissible in Fedora.  rubygem-uglifier will have to be patched to bring
> in source-map and uglify-js separately.

Oh my, this will again bring in dependency on Node or everything will have to
have some -common package and then it has to be somehow put together.

> I can, however, ship a minified version of uglify-js like rubygem-uglifier
> wants, though I'm not sure why it's necessary.

I agree, the minification solves nothing and is useless.

[1] https://github.com/lautis/uglifier/blob/master/lib/uglifier.rb#L114
[2] https://github.com/lautis/uglifier/blob/master/lib/uglifier.rb#L165

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CayTzzVG0O&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]