Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GDAL - Geospatial Data Abstraction Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222042 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-23 12:56 EST ------- Well, for 1.4.0-7.fc7: * BuildRequires - mockbuild log says: ------------------------------------------------------- checking for Xerces C++... disabled ------------------------------------------------------- Can this be enabled by xerces-c-devel? * User dependent rebuild condition? - mockbuild log says: ------------------------------------------------------- Writing /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Geo/GDAL/Const/.packlist Appending installation info to /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod /bin/sh: /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod: Permission denied make[3]: [doc_site_install] Error 1 (ignored) make[3]: Leaving directory `/builddir/build/BUILD/gdal-1.4.0/swig/perl' make -f Makefile_Geo__OGR install ------------------------------------------------------- Well, this can be ignored for mockbuild, however, is this dangerous on rebuilding this package as root? * BuildRoot - BuildRoot does not follow current Fedora guideline (please check "Build root tag" section of http://fedoraproject.org/wiki/Packaging/Guidelines) * Header files location - Well, I think all the header files in -devel package should be hidded under %{_includedir}/%{name} to avoid namespace conflict. - And I suggest to fix %{_bindir}/gdal-config accordingly. - By the way what does "CONFIG_DEP_LIBS" in gdal-config mean? * Directory structure - Well, --------------------------------------------------------- # move python in the right path mv %{buildroot}%{_bindir}/*.py %{buildroot}%{_datadir}/gdal cp -p pymod/samples/*.py %{buildroot}%{_datadir}/gdal --------------------------------------------------------- Just explain why putting these python scripts under %{_bindir} is not right? * .la files - The following files are installed. ---------------------------------------------------------- /usr/lib/python2.5/site-packages/_gdalmodule.la ---------------------------------------------------------- * Redundant dependency - Currently the following explicit dependency are rather redundant. ---------------------------------------------------------- Requires: python >= 2.4 Requires: perl >= 5.8 ---------------------------------------------------------- Check for documentation files and source files may take more time... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review