Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904658 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For 0.5.1-1 * License - Some files are under GPLv3+, and some of them are actually used to build the binary: ----------------------------------------------------- audio/faudiostream/architecture/faust/audio/alsa-dsp.h audio/faudiostream/architecture/faust/audio/coreaudio-dsp.h audio/faudiostream/architecture/faust/audio/netjack-dsp.h audio/faudiostream/architecture/faust/audio/portaudio-dsp.h audio/faudiostream/architecture/faust/gui/console.h audio/faudiostream/architecture/faust/gui/faustqt.h audio/faudiostream/architecture/faust/gui/meta.h faudiostream/architecture/faust/audio/alsa-dsp.h faudiostream/architecture/faust/audio/coreaudio-dsp.h faudiostream/architecture/faust/audio/netjack-dsp.h faudiostream/architecture/faust/audio/portaudio-dsp.h faudiostream/architecture/faust/gui/console.h faudiostream/architecture/faust/gui/faustqt.h faudiostream/architecture/faust/gui/meta.h ----------------------------------------------------- So the license tag should be "GPLv3+" (just GPLv3+ is okay). * Compiler flags - Fedora specific compilation flags are not used correctly. build.log says: ----------------------------------------------------- 33 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.ESDXyl 34 + umask 022 35 + cd /builddir/build/BUILD 36 + cd radium_compressor-0.5.1 37 + make 'OPTS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables' -j5 38 cd Qt && ./create_source_from_ui.sh `../find_moc_and_uic_paths.sh uic` `../find_moc_and_uic_paths.sh moc` compressor_widget 39 g++ -DDEBUG -O3 -Wall -msse -mfpmath=sse -DUSE_QT_REQTYPE -DUSE_QT4 -g -I. -ffast-math -IQt Qt/Qt_SliderPainter.cpp `pkg-config --cflags Qt3Support` -c 40 g++ -DDEBUG -O3 -Wall -msse -mfpmath=sse -DUSE_QT_REQTYPE -DUSE_QT4 -g -I. -ffast-math -IQt main.cpp Qt_SliderPainter.o -Iaudio/faudiostream/architecture/ `pkg-config --libs --cflags Qt3Support` -ljack -o radium_compressor 41 + exit 0 ----------------------------------------------------- Also, "-O3" is used, this should be changed to -O2. And, is it safe for this package to use "-ffast-math"? -ffast-math does some "optimization" which breaks IEEE rules for example, which may result in confusing behavior. * rpmlint issue - incorrect-fsf-address (not a blocker) - Some source files contain incorrest FSF address, which causes rpmlint complaint on debuginfo rpm. Not a blocker, however it is recommend to tell upstream - spurious-executable-perm - rpmlint complains about some header files in debuginfo rpm for having non-proper permission. You can suppress this rpmlint complaint by changing the permission of header files to 0644 at %prep. * Desktop file https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Desktop_files - It seems that "radium_compressor" is a GUI program, so installing proper desktop file is required (unless there is some reason, e.g. this program usually needs proper argument, for example) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CSA0xMvA70&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review