[Bug 894725] Review Request: uglify-js - JavaScript parser, mangler/compressor and beautifier toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894725

--- Comment #15 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
(In reply to comment #13)
> Hm, that is weird. Reading the packaging guidelines "The nodejs package
> includes an automatic Requires and Provides generator that automatically
> adds versioned dependencies based on the information provided in a module's
> package.json file.", I thought that there will be some dependency on node,
> but there is non:

Okay, the problem here is that the RPM dependency generation magic counts on a
file /usr/lib/node_modules/<module_name>/package.json to exist.  Unfortunately,
we need to use absolute symlinks since users can potentially `npm link`
RPM-installed modules anywhere on the system, so the symlink in node_modules is
unresolvable at build time, so RPM can't find the package.json.

I fixed this by changing the way symlinks are done so that
/usr/lib/node_modules/uglify-js/package.json is a real file, and the dependency
generator now works.  I'll fix coffee-script too, which undoubtedly faces the
same issue.

Spec: http://patches.fedorapeople.org/npm/uglify-js.spec
SRPM: http://patches.fedorapeople.org/npm/uglify-js-2.2.3-6.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4922842

Thanks for catching this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GpVV0QvyYu&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]