Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906160 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Konstantin Some initial comments: First, the package don't build on mock, need python-setuptools as BuildRequires. Define python_sitelib or python_sitearch macros not needed in latest releases of Fedora, only needed in el5. See [1] Don't use python-devel as BR, use python2-devel See [2] - the package requires pytz. - Please take a look at ownership of files and directories.[3] %{python_sitelib}/* - the package is compatible with Python3 [4], please build the package with this version too. See [5] - I understand that it is a standalone version but it would not hurt, ask for the Fedora Packaging Committee (fpc) about inclusion of this package in Fedora, See [6] [1] http://fedoraproject.org/wiki/Packaging:Python#Macros [2] http://fedoraproject.org/wiki/Packaging:Python#BuildRequires [3] https://fedoraproject.org/wiki/Packaging:UnownedDirectories [4] http://parenchym.com/pymblog/porting-feedgenerator-to-py3k.html [5] http://fedoraproject.org/wiki/Packaging:Python#Subpackages [6] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Kind Regards Eduardo -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EdW0SrJhVT&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review