Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pikachu.2014@xxxxxxxxx --- Comment #1 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Hello, (In reply to comment #0) > Check redhat bug 883614 for more details. We are planning to upstream > 'open-vm-tools'. "Access denied" :( Just an informal review for the moment. I tested your package on Fedora 18. I see your SRPM package is labelled "f16", be careful this version won't be maintained anymore in a few days. 1) The following dependencies are missing from the BuildRequires: - libXtst-devel Without them, I just can't build your package, the configure step fails. Some others are detected as unavailable during configure, although it doesn't block the build: - fuse-devel (probably to enable sharing support) - libSM-devel - libICE-devel I suggest you to build your packages using mock, to be sure not to forget any BR: http://fedoraproject.org/wiki/Projects/Mock 2) I have issues with procps which can't be found, although procps-ng-devel is installed: configure: error: libproc not found. Please configure without procps (using --without-procps) or install procps - http://procps.sourceforge.net It looks like libproc.so is detected by default by configure, whereas Fedora provides libprocps.so. To fix this issue, I had to: - add procps-ng-devel as BuildRequires - override the default procps library name detected using "export CUSTOM_PROCPS_NAME=procps" before %configure 3) I don't thing glib is really required by openvm-tools. I think you mean glib2 (according to configure.ac, only glib2 is needed). As a result, replace glib by glib2 in BuildRequires. 4) gtk2 is probably not the BuildRequires you want to use. You want gtk2-devel instead. gtk2-devel contains the headers and .so files needed to develop with GTK+2, and required by openvm-tools. 5) BuildRoot tag, BuildRoot cleaning and %clean sections are deprecated: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Please drop all these things. %defattr is useless too in your package: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions Please drop it from the %files section. 6) SysV init scripts are deprecated in favor of systemd unit files: http://fedoraproject.org/wiki/Packaging:Systemd You can't provide anymore such service file, you must convert it to Systemd. 7) Although all the fixes made above, the package build fails with the following error: fileLogger.c: In function 'FileLoggerLog': fileLogger.c:257:4: error: 'g_static_rw_lock_reader_lock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:210): Use 'g_rw_lock_reader_lock' instead [-Werror=deprecated-declarations] fileLogger.c:268:7: error: 'g_static_rw_lock_reader_unlock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:216): Use 'g_rw_lock_reader_unlock' instead [-Werror=deprecated-declarations] fileLogger.c:269:7: error: 'g_static_rw_lock_writer_lock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:219): Use 'g_rw_lock_writer_lock' instead [-Werror=deprecated-declarations] fileLogger.c:273:7: error: 'g_static_rw_lock_writer_unlock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:225): Use 'g_rw_lock_writer_unlock' instead [-Werror=deprecated-declarations] fileLogger.c:274:7: error: 'g_static_rw_lock_reader_lock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:210): Use 'g_rw_lock_reader_lock' instead [-Werror=deprecated-declarations] fileLogger.c:291:13: error: 'g_static_rw_lock_reader_unlock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:216): Use 'g_rw_lock_reader_unlock' instead [-Werror=deprecated-declarations] fileLogger.c:292:13: error: 'g_static_rw_lock_writer_lock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:219): Use 'g_rw_lock_writer_lock' instead [-Werror=deprecated-declarations] fileLogger.c:298:13: error: 'g_static_rw_lock_writer_unlock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:225): Use 'g_rw_lock_writer_unlock' instead [-Werror=deprecated-declarations] fileLogger.c:299:13: error: 'g_static_rw_lock_reader_lock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:210): Use 'g_rw_lock_reader_lock' instead [-Werror=deprecated-declarations] fileLogger.c:309:4: error: 'g_static_rw_lock_reader_unlock' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:216): Use 'g_rw_lock_reader_unlock' instead [-Werror=deprecated-declarations] fileLogger.c: In function 'FileLoggerDestroy': fileLogger.c:331:4: error: 'g_static_rw_lock_free' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:228): Use 'g_rw_lock_free' instead [-Werror=deprecated-declarations] fileLogger.c: In function 'GlibUtils_CreateFileLogger': fileLogger.c:378:4: error: 'g_static_rw_lock_init' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:207): Use 'g_rw_lock_init' instead [-Werror=deprecated-declarations] Could you check it with your devteam? 8) Why do you disable debug package generation(see %global debug_package %{nil}). This is something unacceptable for the Fedora Project, unless you really have a good reason to do it. Could you explain such a choice? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yg7hcmCOBu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review