Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lynx https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226113 varekova@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED CC| |rnorwood@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From varekova@xxxxxxxxxx 2007-02-23 07:43 EST ------- Thanks for your comments. The fixed package is lynx-2.8.6-3.fc7. o /etc/lynx.lss probably should be flagged as %noreplace -> fixed However, the URL for Source in the spec file is incorrect. The correct URL for the current version is: http://lynx.isc.org/current/lynx2.8.6rel.2.tar.bz2 -> lynx2.8.6rel.2.tar.bz2 - is not stable version o dist tag is present. Nope. Needs to be added -> added o build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -> fixed o latest version is being packaged. Almost - there is a 2.8.6rel.4 available from upstream now. -> it is not stable version lynx 2.8.6 is te last stable version o %check is present and all tests pass: No. ->There are no tests in lynx package o file permissions are appropriate. Yes, except might want to chmod -x the sample scripts that are located in /usr/share/doc/lynx-2.8.6/samples/ (rpmlint complains about them) -> I think this files should be leaved as executable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review