Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hyperestraier - A full-text search system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229647 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-02-23 06:09 EST ------- Review: + package builds fine in mock (development i386). + rpmlint is silent for SRPM - rpmlint is NOT silent for RPM. (But following rpmlint warning can be ignored W: hyperestraier-java devel-file-in-non-devel-package /usr/lib/libjestraier.so) + source files match upstream. 70e0533f1ca5247d8187afcb51b8d4e0 hyperestraier-1.4.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + .pc file present. + -devel,-java,-perl, ruby-hyperestraier subpackage exists. + no .la files. + translations are available for Japanese language. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review