Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- Issues similar to those of other reviews... Missing build-time dependency: perl(Carp) Unneeded runtime dependencies: perl(Class::MethodMaker) perl(File::Spec) perl(Scalar::Util) perl(Text::Balanced) Those are automatically picked up by rpmbuild. Lines 40 and 41 are unneeded. None of the files has executable bits set. Line 52 is also unneeded (done by rpmbuild). And the command macros could be replaced with simple calls. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pMbzQ2uH3A&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review