[Bug 891229] nodejs-request - Simplified HTTP request client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891229

--- Comment #20 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to comment #19)
> Spec: http://patches.fedorapeople.org/npm/nodejs-request.spec
> SRPM:
> http://patches.fedorapeople.org/npm/nodejs-request-2.12.0-3.fc17.src.rpm
> 
> The URL works this time, I promise. ;-)
It's an old link :) Using
http://patches.fedorapeople.org/npm/nodejs-request-2.12.0-4.fc17.src.rpm

> (In reply to comment #17)
> > Shouldn't the cookie module be linked to
> > /usr/lib/node_modules/request/node_modules/ ?
> 
> Fixed.
OK. (there is a typo in explaining comment registSry)

But: It is linked as tobi-cookie, but requested as cookie.

>  , Cookie = require('cookie')
>  , CookieJar = require('cookie/jar')

Will this work?

> > What about not adding the nodejs-tobi-cookie dependency manually, but use
> > the %nodejs_fixdep macro? That should add the require and do the link, right?
> 
> No, nodejs-tobi-cookie doesn't provide 'npm(tobi-cookie)' since no
> 'tobi-cookie' module exists in the npm registry.  Therefore, I have to do
> the link manually.  This is also fixed.
OK

(In reply to comment #18)
> I cannot see, where you apply the patch. Am i blind, or you are not doing it?
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kwUxNg0Bq4&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]