[Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> ---
Issues:

Lines 29-31 are useless. None of those files has executable bits set. 
Interval.* isn't even present in the archive.

Line 42 is also not needed as this is done automatically by rpmbuild.

Useless build-time dependency: perl(Test::Simple) -- not used anywhere at all.

Missing build-time dependencies:
perl(Exporter) from lib/Convert/Age.pm:35
perl(Test::More) from various test files

Simple commands are preferred over command macros.  Consider removing them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iLsdsCK8rM&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]