Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904862 --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to comment #1) > Should I move the docs to a "-doc" sub-package? If so, would the > sub-package have to have "Requires: %{name} = %{version}-%{release}"? The sub-package -docs packages don't need to requires the main package, you just need to conform to License Guideline [x]: License file installed when any subpackage combination is installed. So the -docs need to also include the License file. NB: -tests need -docs. > I could not get the tests to pass so I wrapped them in an rpmbuild "--with > tests" conditional. I'd love some help trying to figure out how to get the > tests to pass. Drop the EXAMPLES_DIR change in %prep, and test works. So need to apply this hack in %install (to the buildroot installed file) Warning: some tests use online file, this is not compatible with mock build (ex http://www.bbc.co.uk/music/artists/70248960-cb53-4ea4-943a-edb18f7d336f.rdf) Need to skip this test or use a local copy of the file (check this with upstream) Warning: "Non-PEAR PHP software which provides shared libraries should put its PHP source files for such shared libraries in a subfolder of /usr/share/php, named according to the name of the software. For example, a library called "Whizz_Bang" (with a RPM called php-something-Whizz-Bang) would put the PHP source files for its shared libraries in /usr/share/php/Whizz_Bang. " So there is a problem with /usr/share/php/EasyRdf.php which, according to Guildelines should not be in /usr/share/php, but this make sense for PSR0 compatibility. Need to think about this... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nYTgb3rgr6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review