Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903732 --- Comment #3 from John Morris <john@xxxxxxxxxxx> --- (In reply to comment #2) > (In reply to comment #1) > > How did you find the v0.4 tarball archive? I guess that's the most recent > > release? I've got a specfile for master if it looks interesting; it's more > > complicated, with arch-specific binary RPMs linking numpy, and more BRs and > > Rs. Might not be stable yet. > > I just went to the github page and downloaded the latest tag there. If it's > sufficient for FreeCAD I'm not too worried about packaging master. Ah, they put the 'Tags' tab over on the right away from everything else. Made it practically invisible to a half-blind person like me. You're right, 0.4 will be fine. > > I can add a %check script in there, but if it's like 0.5, it'll need a small > > patch to disable downloading dependencies. > > 0.4 doesn't download anything currently using the standard python setup.py > method. I recommend adding a %check script. It takes a patch to comment out the install_requires line in setup.py; otherwise easy_install will download them from pypi. (Maybe this won't be an issue once the BRs are properly put in place, but it also safeguards against future changes.) Running %checks reveals that numpy and python-dateutil are both Requires: (and BRs, along with python-unittest2, for the checks themselves). Also need a BR for python-setuptools or the mock build will fail. Are group tags needed for EPEL compatibility [1]? If so, here's a candidate used by several python-* packages: Group: Development/Languages I'm putting all these changes on github [2], so feel free to pull/cherry-pick/copy-and-paste from there. Once these are taken care of, I'll write the formal review. [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag [2] https://github.com/zultron/python-collada-rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0RlCzlBYS3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review