Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903762 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Description and Summary OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. $ rpmlint ../SRPMS/nodejs-tobi-cookie-0.3.2-1.fc18.src.rpm ../RPMS/noarch/nodejs-tobi-cookie-0.3.2-1.fc18.noarch.rpm nodejs-tobi-cookie.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-tobi-cookie.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-tobi-cookie.src: W: no-%build-section nodejs-tobi-cookie.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-tobi-cookie.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-tobi-cookie.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 6 warnings. FIX: Add %build section. All others false positives. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK In Readme.md: MIT, OK. MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/tobi-0.3.2.tgz 31d725e601d9f0877550c1f05736c7415da7960f09f57a0ec66c0b66cbee2c67 ../SOURCES/tobi-0.3.2.tgz $ spectool -g nodejs-tobi-cookie.spec Getting http://registry.npmjs.org/tobi/-/tobi-0.3.2.tgz to ./tobi-0.3.2.tgz $ sha256sum tobi-0.3.2.tgz 31d725e601d9f0877550c1f05736c7415da7960f09f57a0ec66c0b66cbee2c67 tobi-0.3.2.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, build in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-tobi-cookie-0.3.2-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 25 17:39 /usr/lib/node_modules/tobi-cookie -rw-r--r-- 1 root root 1041 lis 15 2011 /usr/lib/node_modules/tobi-cookie/index.js -rw-r--r-- 1 root root 1475 lis 15 2011 /usr/lib/node_modules/tobi-cookie/jar.js -rw-r--r-- 1 root root 431 led 25 17:39 /usr/lib/node_modules/tobi-cookie/package.json drwxr-xr-x 2 root root 0 led 25 17:39 /usr/share/doc/nodejs-tobi-cookie-0.3.2 -rw-r--r-- 1 root root 2805 lis 15 2011 /usr/share/doc/nodejs-tobi-cookie-0.3.2/History.md -rw-r--r-- 1 root root 10951 lis 15 2011 /usr/share/doc/nodejs-tobi-cookie-0.3.2/Readme.md OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Package NEEDSWORK: Add build section. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=56TLZDr0nd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review