[Bug 903246] Review Request: cpopen - Creates a subprocess in simpler safer manner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903246

--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
Quickstart help:

* http://fedoraproject.org/wiki/Packaging:Guidelines#Python
* http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
* http://fedoraproject.org/wiki/Packaging:ReviewGuidelines
* http://fedoraproject.org/wiki/Category:Package_Maintainers
*
http://fedoraproject.org/wiki/Category:Package_Maintainers#Packaging_Committee

Run "rpmlint -i" on the src.rpm and all built rpms. Some of the reported
warnings/errors can be dubious (false positives), however. Be aware of that.


> Spec URL: http://bronhaim.fedorapeople.org/cpopen.spec
> SRPM URL: http://bronhaim.fedorapeople.org/python-cpopen-1.0-1.fc17.src.rpm

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 


> This package uses C library

> %build
> 
> 
> %install

It doesn't build anything in %build, but only in %install. That's odd enough,
so it ought to be examined and fixed.


> BuildRequires: python2
> BuildRequires: python-devel

Why the version difference? (even if either one may be a virtual package) It
seems just "BuildRequires: python2-devel" is wanted.


> %{python_sitelib}/createprocess.so*

/usr/lib/python2.7/site-packages/ is the wrong Python module path where to
store an arch-specific (!) shared library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uWKn7Et9nk&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]