Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885038 --- Comment #14 from Christophe Burgun <jouty@xxxxxxxxxxxxxxxxx> --- Hi Antonio, Hi Michael, Thanks for the feedback and sorry for the long delay i takke for answer > Note: Cannot find license.html in rpm(s) This is a fedora-review bug %doc COPYING contain license >For package name i have take default to lowercase naming. > BuildRequires and Requires entries should be listed one-by-one. I have changed each buildrequires and requires entries one-by-one > [-]: %check is present and all tests pass. I have add %check ctest cmake_install.cmake but : Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.PryLyS + umask 022 + cd /builddir/build/BUILD + cd pentobi-5.0 + ctest cmake_install.cmake Test project /builddir/build/BUILD/pentobi-5.0 No tests were found!!! so in check section i have only the desktop-file-validate > Requires: boost,qt in Install notes it is written for this requirements Are you sure that i need put away requires ? > %{_prefix}/games/pentobi > %dir %{_datadir}/games/%{name} > | Data files (maps, pixmaps, sounds) go in %{_datadir}/%{name} , > | not %{_datadir}/games/%{name} . Binaries go in %{_bindir} and > | not /usr/games. According to the FHS, the use of /usr/share/games > | and /usr/games is optional, and we recommend not using either for > | consistency, so that games are packaged like all other applications. https://sourceforge.net/p/pentobi/bugs/7/ for moment i apply the patch and this will be better in the next pentobi version > %{_datadir}/mime/packages/pentobi-mime.xml %post and %postun have been added > %{_datadir}/icons/hicolor/16x16/apps/pentobi.png %post and %postun have been added > %{_datadir}/thumbnailers/pentobi.thumbnailer %dir %{_datadir}/thumbnailers has been added and bugreport has been open https://bugzilla.redhat.com/show_bug.cgi?id=893988 http://lists.fedoraproject.org/pipermail/packaging/2013-January/008850.html Changelog Updated Spec URL: http://jouty.fedorapeople.org/pentobi.spec SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GnLWCzCx67&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review